[pve-devel] applied: [PATCH qemu-server] qemu-img convert: use cache=none for ZFS only

[Thomas Lamprecht]

applied, thanks

(and thanks Alexandre for your reference backed argument :) )

On 3/26/18 10:15 AM, Fabian Grünbichler wrote:
> since this requires O_DIRECT support by the underlying storage, which
> might not be available.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
>  PVE/QemuServer.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 91a2bfc..fe85f39 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -6146,7 +6146,8 @@ sub qemu_img_convert {
>  	my $cmd = [];
>  	push @$cmd, '/usr/bin/qemu-img', 'convert', '-p', '-n';
>  	push @$cmd, '-s', $snapname if($snapname && $src_format eq "qcow2");
> -	push @$cmd, '-t', 'none', '-T', 'none';
> +	push @$cmd, '-t', 'none' if $dst_scfg->{type} eq 'zfspool';
> +	push @$cmd, '-T', 'none' if $src_scfg->{type} eq 'zfspool';
>  	push @$cmd, '-f', $src_format, '-O', $dst_format, $src_path;
>  	if ($is_zero_initialized) {
>  	    push @$cmd, "zeroinit:$dst_path";
>