[pve-devel] [PATCH manager/container] add container clone/template to the gui
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Mar 20 15:30:08 CET 2018
On 3/19/18 1:32 PM, Dominik Csapak wrote:
> this series enables creating container templates and clones from the gui
>
Now with Dietmars patch series applied we can work with the
'target' property name, so this problem is solved.
There are two other problems with this series I found for now:
* container expects a 'hostname' not 'name' property
* currently we use the pveDiskStorageSelector which returns
a diskformat (e.g., qcow2), but for CT this does not makes
sense, either drop it in create_clone for the CT case or
adapt the disk storage selector component, e.g.:
diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js
index 0fdb5c5c..7869d1b3 100644
--- a/www/manager6/form/DiskStorageSelector.js
+++ b/www/manager6/form/DiskStorageSelector.js
@@ -131,6 +131,7 @@ Ext.define('PVE.form.DiskStorageSelector', {
nodename: me.nodename,
disabled: true,
hidden: me.storageContent === 'rootdir',
+ submitValue: me.storageContent !== 'rootdir',
value: 'qcow2',
allowBlank: false
}
> pve-container:
>
> Dominik Csapak (1):
> add features 'clone', 'copy' to api
>
> src/PVE/API2/LXC.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> pve-manager:
>
> Dominik Csapak (5):
> move Clone to window directory
> make clone window guest agnostic
> move TemplateMenu to menu directory
> adapt and rescope TemplateMenu for containers
> make container clones/template available in the gui
>
> www/manager6/Makefile | 4 +--
> www/manager6/Utils.js | 36 ++++++++--------------
> www/manager6/form/SnapshotSelector.js | 6 +++-
> www/manager6/lxc/CmdMenu.js | 48 +++++++++++++++++------------
> www/manager6/lxc/Config.js | 26 ++++++++++++++++
> www/manager6/{qemu => menu}/TemplateMenu.js | 14 ++++++---
> www/manager6/qemu/CmdMenu.js | 2 +-
> www/manager6/qemu/Config.js | 2 +-
> www/manager6/{qemu => window}/Clone.js | 20 +++++++-----
> 9 files changed, 99 insertions(+), 59 deletions(-)
> rename www/manager6/{qemu => menu}/TemplateMenu.js (75%)
> rename www/manager6/{qemu => window}/Clone.js (91%)
>
More information about the pve-devel
mailing list