[pve-devel] [PATCH storage 03/11] Add helper function for extract CIFS credentials.

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Mar 14 14:35:50 CET 2018


On Tue, Mar 13, 2018 at 03:23:10PM +0100, Thomas Lamprecht wrote:
> On 03/13/2018 03:11 PM, Wolfgang Link wrote:
> > ---
> >  PVE/API2/Storage/Config.pm | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm
> > index aa8c931..fa8d4de 100755
> > --- a/PVE/API2/Storage/Config.pm
> > +++ b/PVE/API2/Storage/Config.pm
> > @@ -12,6 +12,7 @@ use HTTP::Status qw(:constants);
> >  use Storable qw(dclone);
> >  use PVE::JSONSchema qw(get_standard_option);
> >  use PVE::RPCEnvironment;
> > +use Term::ReadLine;
> >  
> please do not use Term::ReadLine anymore, rather use Wolfgang B.'s
> nice PTY module, i.e.:

Also this should be CLI-only, and therefore handled in in CLI/pvesm.pm
via the new parameter mapping functionality instead of having this in
API2/Storage/Config.pm

In the API, just don't set a password if it hasn't been provided.



More information about the pve-devel mailing list