[pve-devel] [PATCH manager v2 00/17] clean up buildsys, postinst and legacy files

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Mar 12 14:13:51 CET 2018


v2 of this series.

changes v1 -> v2:
* wrap transitional parts in a version dependent way, easier to know
  what to remove in a future version and no need to always do this
  stuff.
* do not overwrite user configured .forward's allways append ours
* fix some typos
* drop v1 15/15, we're not yet ready for fully autogenerated systemd
  helpers
* add tree patches insteads which swap out those manual helper where it
  can work and clean up a bit more

v1 cover letter:
> This series started with the goal to make the debian/postinst file
> readable again and tries to cleanup stuff I found during trying that.
> 
> I shallowly discussed some of those changes with Fabian already off
> list but as this is (yet another) change to a fundamental stuff
> from me, it obviously needs another good look.
> 
> Further, I did not yet tested this in the installer environment.
> The main change there is that I do not skip systemd stuff in in this
> environment, this mirrors the behavior of other packages.

Thomas Lamprecht (17):
  remove obsolete (rgmanager era) HA resource agent
  buildsys: add %.1.pod make target to reduce duplication
  services: remove obsolete init.d scripts
  postinst: purge all old init.d service files on upgrade
  buildsys: remove unused debconf template
  postinst: removing old APL dir is obsolete
  postinst: bootlogd is not used under systemd
  postinst: simplify root's mail .forward check
  postinst: combine abort-* cases and remove boilerplate cruft
  postinst: simplify code for transitional updates
  postinst: remove fixup for ceph jewel update transition
  postinst: remove commented out call to a2ensite
  postinst: remove pvebanner call
  pveupdate: replace cron job with systemd timer
  b/postrm: let debhelper generate systemd stuff
  buildsys: remove outdated preinst helper
  b/prerm: cleanup cruft from prerm helper

 bin/Makefile                        |  17 +-
 bin/init.d/Makefile                 |  15 +-
 bin/init.d/pve-daily-update.service |   9 +
 bin/init.d/pve-daily-update.timer   |  10 +
 bin/init.d/pvebanner                |  33 --
 bin/init.d/pvedaemon                |  49 ---
 bin/init.d/pveproxy                 |  60 ----
 bin/init.d/pvestatd                 |  54 ----
 bin/init.d/spiceproxy               |  60 ----
 bin/ocf/Makefile                    |  14 -
 bin/ocf/pvevm                       | 599 ------------------------------------
 debian/config                       |  10 -
 debian/control                      |   1 -
 debian/postinst                     | 108 +------
 debian/postrm                       |  34 +-
 debian/preinst                      |  32 --
 debian/prerm                        |  41 +--
 debian/rules                        |   2 +-
 debian/templates                    |   3 -
 19 files changed, 44 insertions(+), 1107 deletions(-)
 create mode 100644 bin/init.d/pve-daily-update.service
 create mode 100644 bin/init.d/pve-daily-update.timer
 delete mode 100755 bin/init.d/pvebanner
 delete mode 100755 bin/init.d/pvedaemon
 delete mode 100755 bin/init.d/pveproxy
 delete mode 100755 bin/init.d/pvestatd
 delete mode 100755 bin/init.d/spiceproxy
 delete mode 100644 bin/ocf/Makefile
 delete mode 100755 bin/ocf/pvevm
 delete mode 100755 debian/config
 delete mode 100644 debian/preinst
 delete mode 100644 debian/templates

-- 
2.14.2





More information about the pve-devel mailing list