[pve-devel] [PATCH v4 qemu-server 03/10] implement cloudinit

Wolfgang Bumiller w.bumiller at proxmox.com
Tue Mar 6 08:03:57 CET 2018


On Tue, Mar 06, 2018 at 07:16:32AM +0100, Dietmar Maurer wrote:
> 
> >  use PVE::Cluster qw (cfs_read_file cfs_write_file);;
> >  use PVE::SafeSyslog;
> > @@ -64,7 +65,9 @@ my $check_storage_access = sub {
> >  
> >  	my $volid = $drive->{file};
> >  
> > -	if (!$volid || $volid eq 'none') {
> > +	if (!$volid || ($volid eq 'none' || $volid eq 'cloudinit')) {
> > +	    # nothing to check
> > +	} elsif ($volid =~ m/^(([^:\s]+):)?(cloudinit)$/) {
> 
> Why two different checks for 'cloudinit'? The regex also match 'cloudinit', so
> the
> first test is useless?

Looks like a left-over from a previous variant where we hadn't put the
image onto a storage.



More information about the pve-devel mailing list