[pve-devel] [PATCH V3 storage 0/4] updated Linux targetcli/LIO support

Stoiko Ivanov s.ivanov at proxmox.com
Fri Jun 29 14:19:54 CEST 2018


Hi,

Thank you very much for the patches and your work!
I'll try to review/test them next week and provide some feedback.

Regarding the last patch (fixing of the typo) - you could squash that
into the previous commit, which would have the upside that all commits
are syntactically correct. The article at
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History gives a nice
overview of the possibilities of interactive rebasing.
However this is just a suggestion, and not material to these patches -
we will happily do those tiny fixups when applying the patches.

Thanks again,
stoiko

On Fri, 29 Jun 2018 10:00:51 +0200
Udo Rader <udo.rader at bestsolution.at> wrote:

> fixed a typo that prevented LIO.pm from loading
> 
> Udo Rader (4):
>   adding linux LIO support
>   adding linux LIO support
>   expiring cached iSCSI configuration after 15 seconds, after which it
>     is re-read from the portal
>   fixed syntax error, preventing LIO.pm from loading
> 
>  PVE/Storage/LunCmd/LIO.pm   | 407
> ++++++++++++++++++++++++++++++++++++ PVE/Storage/LunCmd/Makefile |
> 2 +- PVE/Storage/ZFSPlugin.pm    |   7 +-
>  3 files changed, 414 insertions(+), 2 deletions(-)
>  create mode 100644 PVE/Storage/LunCmd/LIO.pm
> 




More information about the pve-devel mailing list