[pve-devel] [PATCH qemu-server 1/2] add hv_stimer, hv_synic cpu flags option

Dominik Csapak d.csapak at proxmox.com
Wed Jun 27 10:29:41 CEST 2018


this does not work, because with that regex we need to define
+hv_synic;+hv_stimer
but this does not work of course

i believe the correct regex would be

qr/(?:[+-](pcid|spec-ctrl)|hv_(stimer|synic))/

or maybe let the +/- optional and add it for pcid/spec-ctlr/future flags?

On 06/24/2018 08:47 PM, Alexandre Derumier wrote:
> ---
>   PVE/QemuServer.pm | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index d6efb3a..1e4ac5d 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -155,7 +155,7 @@ my $cpu_vendor_list = {
>       max => 'default',
>   };
>   
> -my $cpu_flag = qr/[+-](pcid|spec-ctrl)/;
> +my $cpu_flag = qr/[+-](pcid|spec-ctrl|hv_stimer|hv_synic)/;
>   
>   my $cpu_fmt = {
>       cputype => {
> @@ -174,7 +174,7 @@ my $cpu_fmt = {
>       flags => {
>   	description => "List of additional CPU flags separated by ';'."
>   		     . " Use '+FLAG' to enable, '-FLAG' to disable a flag."
> -		     . " Currently supported flags: 'pcid', 'spec-ctrl'.",
> +		     . " Currently supported flags: 'pcid', 'spec-ctrl', 'hv_stimer', 'hv_synic'.",
>   	format_description => '+FLAG[;-FLAG...]',
>   	type => 'string',
>   	pattern => qr/$cpu_flag(;$cpu_flag)*/,
> 




More information about the pve-devel mailing list