[pve-devel] [PATCH access-control v5 0/5] refactor API and introduce list commands

Stoiko Ivanov s.ivanov at proxmox.com
Thu Jun 21 14:31:42 CEST 2018


The last two patches rely on the already applied changes to pve-common, maybe
we want to raise the dependency version upon packaging.

Changes from v4:
* split up commits into hopefully sensible chunks
* leave the userid option in PVE::Auth::Plugin, and add userid-completed in
  PVE::AccessControl, which then gets used in the API2 modules
* fix a bug in v4, which broke ticket generation/login
  (thanks for catching it @Thomas!)
* I ran some very rudimentary tests on each commit (create user via pvesh,
  get login ticket, try to recreate the user, delete the user) for every commit


Stoiko Ivanov (5):
  fix PVE::AccessControl::role_is_special
  PVE::AccessControl: register userid with completion
  refactor API using get/register_standard_option
  Add title and print_width fields to properties
  pveum: add list and dump commands

 PVE/API2/ACL.pm           |  36 +++++++------
 PVE/API2/AccessControl.pm |  12 ++---
 PVE/API2/Group.pm         |  37 +++++++------
 PVE/API2/Role.pm          |  54 ++++++++++++-------
 PVE/API2/User.pm          | 135 +++++++++++++++++++++++-----------------------
 PVE/AccessControl.pm      |   8 ++-
 PVE/Auth/Plugin.pm        |   2 +-
 PVE/CLI/pveum.pm          |  20 +++++++
 8 files changed, 175 insertions(+), 129 deletions(-)

-- 
2.11.0




More information about the pve-devel mailing list