[pve-devel] [PATCH proxmox-widget-toolkit] add missing vlan type in network panel

Alexandre DERUMIER aderumier at odiso.com
Tue Jun 19 13:17:43 CEST 2018


>>minor details, but, anything against calling it 'Linux VLAN'? 
>>Interface seems a bit redundant here and we don't have it 
>>on the other types... 
>>(I can fix it up if you do not mind :) )

yes, sure no problem

----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Mardi 19 Juin 2018 11:48:31
Objet: Re: [pve-devel] [PATCH proxmox-widget-toolkit] add missing vlan type in network panel

On 6/19/18 10:47 AM, Alexandre Derumier wrote: 
> Currently a vlan interface is correctly parsed, 
> but GUI display it as unknown 
> --- 
> Utils.js | 1 + 
> 1 file changed, 1 insertion(+) 
> 
> diff --git a/Utils.js b/Utils.js 
> index 7a4c1d6..d9aa042 100644 
> --- a/Utils.js 
> +++ b/Utils.js 
> @@ -405,6 +405,7 @@ Ext.define('Proxmox.Utils', { utilities: { 
> eth: gettext("Network Device"), 
> bridge: 'Linux Bridge', 
> bond: 'Linux Bond', 
> + vlan: 'Linux Vlan Interface', 

minor details, but, anything against calling it 'Linux VLAN'? 
Interface seems a bit redundant here and we don't have it 
on the other types... 
(I can fix it up if you do not mind :) ) 

> OVSBridge: 'OVS Bridge', 
> OVSBond: 'OVS Bond', 
> OVSPort: 'OVS Port', 
> 



More information about the pve-devel mailing list