[pve-devel] [PATCH ifupdown2] allow address on vlan aware bridge

[Alexandre DERUMIER]

>>Do you think upstream might accept this? I find it rather weird that 
>>this needs patching. I've always been using this kind of setup with 
>>regular ifupdown. 

I'm not sure they will accept it

"
https://github.com/CumulusNetworks/ifupdown2/issues/58

@aderumier, we added that warning because we did not see a use case for a
vlan aware bridge having an ip. You create a vlan interface on top of the
vlan aware bridge to have an address on that vlan and for L3. The warning
being there was a result of too many misconfigs with ip and vlan aware
bridges.

But yes, Nothing stops you from assigning an ip on a vlan aware bridge
netdev on Linux. If you have a use-case where you need packets passed up
the stack on the bridge device PVID and it having an address, pls let us
know. thanks.
"

Maybe can you try to add a comment to push it ?

I can't test it in my network environement as default vlan is disabled.


----- Mail original -----
De: "Wolfgang Bumiller" <w.bumiller at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 18 Juin 2018 10:02:51
Objet: Re: [pve-devel] [PATCH ifupdown2] allow address on vlan aware bridge

Do you think upstream might accept this? I find it rather weird that 
this needs patching. I've always been using this kind of setup with 
regular ifupdown. 

On Sat, Jun 16, 2018 at 03:07:23PM +0200, Alexandre Derumier wrote: 
> --- 
> .../0005-allow-address-on-vlan-aware-bridge.patch | 33 ++++++++++++++++++++++ 
> debian/patches/series | 1 + 
> 2 files changed, 34 insertions(+) 
> create mode 100644 debian/patches/pve/0005-allow-address-on-vlan-aware-bridge.patch 
> 
> diff --git a/debian/patches/pve/0005-allow-address-on-vlan-aware-bridge.patch b/debian/patches/pve/0005-allow-address-on-vlan-aware-bridge.patch 
> new file mode 100644 
> index 0000000..5f44911 
> --- /dev/null 
> +++ b/debian/patches/pve/0005-allow-address-on-vlan-aware-bridge.patch 
> @@ -0,0 +1,33 @@ 
> +From e74d34a4e5c85f98683c61558c8fae8453d2b412 Mon Sep 17 00:00:00 2001 
> +From: Alexandre Derumier <aderumier at odiso.com> 
> +Date: Sat, 16 Jun 2018 14:59:46 +0200 
> +Subject: [PATCH] allow address on vlan aware bridge 
> + 
> +This will allow to setup ip address on vlan aware bridge. 
> +Note that in this case, the ip will use the default PVID. 
> +--- 
> + ifupdown2/ifupdown/utils.py | 8 -------- 
> + 1 file changed, 8 deletions(-) 
> + 
> +diff --git a/ifupdown2/ifupdown/utils.py b/ifupdown2/ifupdown/utils.py 
> +index f7a89a7..cee3425 100644 
> +--- a/ifupdown2/ifupdown/utils.py 
> ++++ b/ifupdown2/ifupdown/utils.py 
> +@@ -346,14 +346,6 @@ class utils(): 
> + else: 
> + cls.logger.info(msg) 
> + return False 
> +- elif (ifaceobj.link_kind & ifaceLinkKind.BRIDGE 
> +- and ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_VLAN_AWARE): 
> +- msg = '%s bridge vlan aware interfaces' 
> +- if syntax_check: 
> +- cls.logger.warning(msg) 
> +- else: 
> +- cls.logger.info(msg) 
> +- return False 
> + return True 
> + 
> + @classmethod 
> +-- 
> +2.11.0 
> + 
> diff --git a/debian/patches/series b/debian/patches/series 
> index 844d2f5..510229f 100644 
> --- a/debian/patches/series 
> +++ b/debian/patches/series 
> @@ -4,3 +4,4 @@ pve/0001-config-tuning.patch 
> pve/0002-manual-interfaces-set-link-up.patch 
> pve/0003-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch 
> pve/0004-add-dummy-mtu-bridgevlanport-modules.patch 
> +pve/0005-allow-address-on-vlan-aware-bridge.patch 
> -- 
> 2.11.0