[pve-devel] [PATCH v3] Add list and dump commands to pveum, refactor API

Stoiko Ivanov s.ivanov at proxmox.com
Tue Jun 12 12:41:44 CEST 2018


changes from v2 (sent as two separate threads for pve-common and
pve-access-control on 29.05.2018):

* only changed the coderef invocation syntax in the areas I touched anyways
  (to keep the git history)
* incorporated Thomas feedback (thanks!)
* added another property to the JSONSchema for defining the maximal width used
  for printing.

Am not really sure about the naming of the methods and the property
(print_api_list, print_width) - would be grateful for suggestions

Rene pointed out a first possible enhancement of adding also a minimal width
for printing (will be sent as a separate patch).

Stoiko Ivanov (3):
  add print_width property to JSONSchema definition
  add print_text_table, print_entry to CLIHandler
  add print_api_list, adapt handle_cmd

 src/PVE/CLIHandler.pm | 94 +++++++++++++++++++++++++++++++++++++++++++++++++--
 src/PVE/JSONSchema.pm |  5 +++
 2 files changed, 97 insertions(+), 2 deletions(-)

Stoiko Ivanov (2):
  refactor API by unifying duplicate properties
  pveum: add list and dump commands

 PVE/API2/ACL.pm      | 40 ++++++++++++----------
 PVE/API2/Group.pm    | 38 +++++++++-----------
 PVE/API2/Role.pm     | 58 ++++++++++++++++---------------
 PVE/API2/User.pm     | 97 +++++++++++++++++++---------------------------------
 PVE/AccessControl.pm |  2 +-
 PVE/Auth/Plugin.pm   |  2 +-
 PVE/CLI/pveum.pm     | 20 +++++++++++
 7 files changed, 127 insertions(+), 130 deletions(-)

-- 
2.11.0




More information about the pve-devel mailing list