[pve-devel] [PATCH manager v3 2/2] Add cephfs to allowed storages for vzdump backup

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jun 12 11:25:49 CEST 2018


On 6/11/18 11:31 AM, Alwin Antreich wrote:
> Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
> ---
>  PVE/VZDump.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index a0376ef9..7fc69f98 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -223,7 +223,7 @@ sub storage_info {
>   
>      die "can't use storage type '$type' for backup\n" 
>  	if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs'
> -	      || $type eq 'cifs'));
> +	      || $type eq 'cifs' || $type eq 'cephfs'));
>      die "can't use storage '$storage' for backups - wrong content type\n" 
>  	if (!$scfg->{content}->{backup});
>  
> 

Hmm, déjà vu[1]... ;-)

This checking really needs to be improved! We need some way to tell
if that, and possible other content type related stuff can be done
per storage plugin. That would also help external plugins, as
Wolfgang replied to [1].

You do not need to to this now, but it would be really nice if
someone (maybe You, Stoiko or Rene?) could put it on their todo
list for the near future :-)

cheers,
Thomas

[1]: https://pve.proxmox.com/pipermail/pve-devel/2018-May/031890.html




More information about the pve-devel mailing list