[pve-devel] [PATCH qemu-server 0/8] implement some guest-agent api calls

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 8 10:11:11 CEST 2018


On 6/7/18 1:16 PM, Dominik Csapak wrote:
> this series adds some useful api calls that make use of the qemu-guest-agent
> like
> set-user-password
> exec
> file-read
> file-write
> 
> it also adds some to qm
> 

A general comment:
can we add those commands to qm through a 'qga' parent command? E.g.:

qm qga excec ...
qm qga passwd ...
qm qga readfile ...
qm qga writefile ...

a) make it clear that this is thorugh qga
b) qm is quite big and maybe somewhat confusing for users not to
   experienced with it so this helps in grouping and when getting
   help, as `qm help qga` get's possible - which only outputs the
   qga commands then.

I try to give the code a look!

> i plan to implement a 'qm push' and 'qm pull' in the future,
> but i wanted to send the things i finished up until now,
> so that they can get reviewed
> 
> Dominik Csapak (8):
>   refactor Makefile for PVE/QemuServer/ directory
>   add Agent helper package
>   implement set-user-password guest agent api call
>   add 'set-user-password' to qm
>   implement agent exec api call
>   add exec(-status) to qm
>   implement file-read api call via guest-agent
>   implement file-write via guest-agent in the api
> 
>  PVE/API2/Qemu/Agent.pm  | 285 +++++++++++++++++++++++++++++++++++++++++++++++-
>  PVE/CLI/qm.pm           |  84 ++++++++++++++
>  PVE/QemuServer/Agent.pm |  92 ++++++++++++++++
>  PVE/QemuServer/Makefile |  17 +--
>  4 files changed, 467 insertions(+), 11 deletions(-)
>  create mode 100644 PVE/QemuServer/Agent.pm
> 




More information about the pve-devel mailing list