[pve-devel] [PATCH manager 1/1] add ebtables_enable option to cluster fw-settings

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jun 5 08:47:21 CEST 2018


On 6/4/18 3:43 PM, Stoiko Ivanov wrote:
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  www/manager6/grid/FirewallOptions.js | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/www/manager6/grid/FirewallOptions.js b/www/manager6/grid/FirewallOptions.js
> index 4c6dc5d0..70046214 100644
> --- a/www/manager6/grid/FirewallOptions.js
> +++ b/www/manager6/grid/FirewallOptions.js
> @@ -88,6 +88,7 @@ Ext.define('PVE.FirewallOptions', {
>  	    add_log_row('log_level_out');
>  	} else if (me.fwtype === 'dc') {
>  	    add_boolean_row('enable', gettext('Firewall'), 0);
> +	    add_boolean_row('ebtables_enable', gettext('ebtables'), 1);

I wouldn't gettext that, ebtables is a project/technology name which
we normally do not translate.

What do you think about calling the option just ebtables in the API?
IMO, boolean values should avoid encoding a boolean name, if possible.
E.g., a config line which effectively states: "ebtables_enable: disable"
looks a bit weird to me.

Looks OK besides that.

>  	}
>  
>  	if (me.fwtype === 'dc' || me.fwtype === 'vm') {
> 




More information about the pve-devel mailing list