[pve-devel] applied: [PATCH manager] fix doubleclick on vm with spice console

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jul 30 11:56:53 CEST 2018


Am 07/30/2018 um 11:37 AM schrieb Dominik Csapak:
> allowSpice needs to be a real boolean, because of a
> '=== true' check to open a spice console if allowed, so make it one here
> 
> this fixes the issue that a doubleclick on a tree item only opened
> the novnc console even if spice is the default and the vm is spice
> enabled
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>   www/manager6/Utils.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 21153ece..c062b591 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -880,7 +880,7 @@ Ext.define('PVE.Utils', { utilities: {
>   		    Ext.Msg.alert('Error', response.htmlStatus);
>   		},
>   		success: function(response, opts) {
> -		    var allowSpice = response.result.data.spice;
> +		    var allowSpice = !!response.result.data.spice;
>   		    PVE.Utils.openDefaultConsoleWindow(allowSpice, 'kvm', vmid, nodename, vmname);
>   		}
>   	    });
> 

applied, thanks!




More information about the pve-devel mailing list