[pve-devel] applied: [pve-common] getopt_usage: always remove $standard_output_options

Dietmar Maurer dietmar at proxmox.com
Fri Jul 27 07:49:34 CEST 2018


Tools like pvesh and pveclient pass them as normal arguments. We use
a simply heuristic to test if there is an 'output_format' parameter.
If so, we remove all $standard_output_options and display [FORMAT_OPTIONS]
instead.

Signed-off-by: Dietmar Maurer <dietmar at proxmox.com>
---
 src/PVE/RESTHandler.pm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm
index e395b95..ed76863 100644
--- a/src/PVE/RESTHandler.pm
+++ b/src/PVE/RESTHandler.pm
@@ -624,6 +624,16 @@ sub getopt_usage {
 	}
     }
 
+    # also remove $standard_output_options from $prop (pvesh, pveclient)
+    if ($prop->{'output-format'}) {
+	$has_output_format_option = 1;
+	foreach my $key (keys %$prop) {
+	    if ($standard_output_options->{$key}) {
+		delete $prop->{$key};
+	    }
+	}
+    }
+
     my $out = '';
 
     my $arg_hash = {};
-- 
2.11.0




More information about the pve-devel mailing list