[pve-devel] [PATCH V3 storage 0/4] updated Linux targetcli/LIO support

[Udo Rader]

On Wed, 2018-07-11 at 19:50 +0200, Stoiko Ivanov wrote:
> Hi,
> 
> I finally got around to give your patches a spin, and can report that
> they work for my preliminary tests.
> 
> One thing, which I think is not a good idea is the reuse of the
> comstar_tg property for the tpg of LIO (from my understanding they do
> serve somewhat different purposes). Should we introduce it like that,
> we will be stuck with supporting this syntax for backwards
> compatibility. We should probably introduce a different optional
> property "lio_tpg" and initially just present it along with the
> others
> in the GUI dialog. What would your opinion be on that?
> 
> Most possible places for some refactoring we saw apply to the iet 
> implementation you based your patches on as well, but if you feel
> like
> it, it would be great to use the new implementation for an initial
> cleanup.
> 
> One thing which would probably be nice is to remove the created zvol,
> if the subsequent creation of the lun fails (I stumbled upon that by
> having a typo in the iqn of the target).

I've now had a little time to refactor the implementation according to
your remarks:

* new tpg_lio property instead of using the comstar_tg property
While this works of course, it has added another optional input field
to the Add: ZFS over iSCSI" dialog. 

Ideally options like these should only be visible depending on the
state of another field (in this case, if "LIO" has been selected as the
iSCSI provider), but unfortunately I didn't find an (easy) way to
implement this. Looks like this is a feature missing in general from
the proxmox UI :)

* Removing a created zvol in case the target has not been set up
correctly
The best way to handle this for any ZFS via iSCSI implementation would
be to verify the connection after the user has entered the connection
data, preventing the scenario you describe all together.

While this doesn't look to difficult to implement, I decided against it
because this would require changes to all other iSCSI providers as
well. Unfortunately I don't have access to other iSCSI servers but LIO
based ones, and so I don't really feel comfortable changing code for
the other providers.

The rest of your remarks has been incorporated.

Cheers

Udo

-- 
Udo Rader, GF/CEO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20180726/77b974e3/attachment.sig>