[pve-devel] api-viewer: allow to re-use ExtJS + Theme when on PVE

[Dominik Csapak]

On 07/25/2018 04:27 PM, Thomas Lamprecht wrote:
> Am 07/25/2018 um 01:12 PM schrieb Dominik Csapak:
>> On 07/25/2018 11:21 AM, Thomas Lamprecht wrote:
>>> changes from v1 [0]:
>>> * add 2 docs (1/3, 2/3) patches to move from debug to release extjs 
>>> and from
>>>    touch to normal theme. Those are independent from the manager 
>>> patch, only
>>>    docs 3/3 needs it.
>>> * s/Build-Depends/Depends/ in the pve-docs control file - addressing 
>>> Fabians
>>>    rightful nit
>>>
>>> [0]: https://pve.proxmox.com/pipermail/pve-devel/2018-July/033021.html
>>>
>>>
>>>
>>> _______________________________________________
>>> pve-devel mailing list
>>> pve-devel at pve.proxmox.com
>>> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>>
>>
>> a comment to docs 3/3 and to the manager patch
>>
>> why not use the paths we have for our main web interface instead?
>>
>> e.g. /pve2/ext6/ext-all.js
>>
>> ?
>>
> 
> As already stated in the patch I want to have this to work for the
> external hosted pve-docs too and the cost to have the link is zero, from
> the CI message:
> 
>> [...]
>> Add a dependency on libjs-extjs and a link from api-viewer/extjs to
>> the installation directory of the ExtJS package, this allows to reuse
>> ExtJS on PVE node hosted docs and on the hosted docs from proxmox.com
>> at the same time.

oh ok, yeah that makes sense, i somehow missed this
(of course we could just host the files in the wiki too, but that is 
probably more work than doing it this way)

+1