[pve-devel] nak: [PATCH common v2 0/3] cli_handler: add output parameters conditionally

[Wolfgang Bumiller]

On Mon, Jul 16, 2018 at 08:58:57PM +0200, Stoiko Ivanov wrote:
> As indicated in the patch sent earlier today the first patch fixes the problem
> of receiving duplicate notifications from a scheduled vzdump invocation.
> 
> Changes from v1: the output parameters are added only to those cli methods,
> that have an output sub defined.
> 
> Additionally the parameters are added to the usage message generation and
> bash-completion.

NAK.

For a heuristic like this for unfinished functionality we don't yet
really make use of this is scattered across too many places and I don't
feel like it'll cover the cases properly. Eg. the existence of an
output-sub is not a very strong condition without knowing what it
actually does. And renaming the options in the "background" is not
really transparent.