[pve-devel] [PATCH qemu-server] qm: move 'agent' command into 'ga' and add alias

[Thomas Lamprecht]

On 07/11/2018 03:28 PM, Dietmar Maurer wrote:
>> On July 11, 2018 at 3:20 PM Dietmar Maurer <dietmar at proxmox.com> wrote:
>>
>>
>> unrelated, bu what exactly is 'ga'? Can't we simply call that 'guest-agent'?
> or maybe only 'guest' (if 'guest-agent' is too long).
>
> # qm guest cmd
> # qm guest exec
> # qm guest password

Yes, sounds good to me!
AFAIK, Dominik's idea for 'ga' was that QEMU uses qga as name for the QEMU
guest agent on almost all places, and as we have the q already in 'qm' he
omitted it, thus qm ga ...

and guest-agent could work to, as long as no other command starting with 'guest'
gets added (unlikely) you can just write 'qm guest <cmd>' - the CLI handler
resolves it still correctly...

>>> -    agent  => [ "PVE::API2::Qemu::Agent", 'agent', ['vmid', 'command'],
>>> -		{ node => $nodename }, $print_agent_result ],
>>> +    agent  => { alias => 'ga cmd' },
>>>   
>>>       ga => {
>>> +	cmd  => [ "PVE::API2::Qemu::Agent", 'agent', ['vmid', 'command'], { node
>>> =>
>>> $nodename }, $print_agent_result ],