[pve-devel] [PATCH v2] improve serial terminal handling

[Thomas Lamprecht]

On 1/26/18 11:57 AM, Dominik Csapak wrote:
> this series adds the ability to show serial ports on the gui,
> and disabling the xtermjs button when no serial device exists for the vm
> 
> changes from v1:
> * rebase on current master
> * changed icon to thomas version, thanks :)
> 
> qemu-server:
> 
> Dominik Csapak (1):
>   add serial:1 to vmstatus when config has a serial device configured
> 
>  PVE/QemuServer.pm | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> pve-manager:
> 
> Dominik Csapak (4):
>   add icon/class for serial ports
>   change group of unused to 99 to that we can add things in between
>   show serial ports on the gui
>   enable/disable xtermjs depending on the existance of a serial port
> 
>  www/css/ext6-pve.css                 |  7 ++++
>  www/images/Makefile                  |  7 +++-
>  www/images/icon-serial.svg           | 65 ++++++++++++++++++++++++++++++++++++
>  www/manager6/button/ConsoleButton.js |  8 +++++
>  www/manager6/qemu/Config.js          |  3 ++
>  www/manager6/qemu/HardwareView.js    | 11 +++++-
>  6 files changed, 99 insertions(+), 2 deletions(-)
>  create mode 100644 www/images/icon-serial.svg
> 

Series looks good.

It should be worth a though about allowing a VM admin to delete the serial
console too, maybe only for the case when it's a 'socket' one.
Maybe adding a 'socket' type one would be also OK for a VM admin.
But that can be done in a later moment, if someone really wants this.

Reviewed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
Tested-by: Thomas Lamprecht <t.lamprecht at proxmox.com>