[pve-devel] [PATCH] use widget-toolkit in pve-manager

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jan 16 10:57:20 CET 2018


On 1/15/18 3:17 PM, Dominik Csapak wrote:
> this series contains necessary port from pve-manager for
> proxmox widget toolkit
> and a v2 of my series to the pve-manager changes
> 
> changes to v1:
> incorporated feedback from thomas
> included button and utils patch
> 
> proxmox-widget-toolkit:
> 
> Dominik Csapak (15):
>   add version as comment to js file
>   check earlier if the logview is destroyed
>   add the missing explanation of onlineHelp
>   pass given defaults in Edit window
>   change invalid class
>   place space on correct side of colon
>   explicit set button focus respecting the 'dangerous' option
>   fix var assignments
>   ComboGrid: improve setting 'editable' default value
>   ComboGrid: open picker also when focusing an editable field
>   add all languages from pve
>   remove unnecessary formatter
>   add task_desc_table and format_task_description from pve
>   add proxmoxlib to the clean target
>   reintroduce api2request checks for toolkit
> 
>  Makefile            |   6 ++-
>  Utils.js            | 134 +++++++++++++++++++++++++++++++++++++++++-----------
>  button/Button.js    |   6 ++-
>  form/ComboGrid.js   |  29 ++++++++++--
>  node/ServiceView.js |   2 +-
>  node/Tasks.js       |   2 +-
>  panel/LogView.js    |   3 +-
>  window/Edit.js      |   9 +++-
>  8 files changed, 151 insertions(+), 40 deletions(-)
> 

For all of the proxmox widget toolkit patches:

Reviewed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>

Could be applied already, IMO.
I'll take a deeper look at the new parts of the manager series now.




More information about the pve-devel mailing list