[pve-devel] [PATCH manager] fix #1573: show bootdisk usage on container summary

Wolfgang Bumiller w.bumiller at proxmox.com
Thu Jan 11 12:52:16 CET 2018


On Fri, Jan 05, 2018 at 10:37:38AM +0100, Dominik Csapak wrote:
> any comment ?

This is fine for running containers, but for stopped containers we
should rather remove the percentage & bar again instead of saying it's
using 0% of the disk. For CPU/Memory/Swap it makes sense that a stopped
container is using 0%, but for the disks not so much.

> On 11/28/2017 02:06 PM, Dominik Csapak wrote:
> > we have the information, so show it
> > this does not change the output for vms, where we do not have
> > any information about disk usage at all
> > 
> > Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> > ---
> >   www/manager6/panel/GuestStatusView.js | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
> > index 26415437..7cebe1b9 100644
> > --- a/www/manager6/panel/GuestStatusView.js
> > +++ b/www/manager6/panel/GuestStatusView.js
> > @@ -63,6 +63,12 @@ Ext.define('PVE.panel.GuestStatusView', {
> >   	{
> >   	    itemId: 'rootfs',
> >   	    title: gettext('Bootdisk size'),
> > +	    valueField: 'disk',
> > +	    maxField: 'maxdisk'
> > +	},
> > +	{
> > +	    itemId: 'bootdisk',
> > +	    title: gettext('Bootdisk size'),
> >   	    textField: 'maxdisk',
> >   	    printBar: false,
> >   	    renderer: PVE.Utils.render_size
> > @@ -88,6 +94,9 @@ Ext.define('PVE.panel.GuestStatusView', {
> >   	me.callParent();
> >   	if (me.pveSelNode.data.type !== 'lxc') {
> >   	    me.remove(me.getComponent('swap'));
> > +	    me.remove(me.getComponent('rootfs'));
> > +	} else {
> > +	    me.remove(me.getComponent('bootdisk'));
> >   	}
> >   	me.getComponent('node').updateValue(me.pveSelNode.data.node);
> >       }
> > 




More information about the pve-devel mailing list