[pve-devel] [PATCH] improve serial terminal handling

[Thomas Lamprecht]

On 1/3/18 1:04 PM, Dominik Csapak wrote:
> this series adds the ability to show serial ports on the gui,
> and disabling the xtermjs button when no serial device exists for the vm
> 
> qemu-server:
> 
> Dominik Csapak (1):
>   add serial:1 to vmstatus when config has a serial device configured
> 
>  PVE/QemuServer.pm | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> pve-manager:
> 
> Dominik Csapak (4):
>   add icon/class for serial ports
>   change group of unused to 99 to that we can add things in between
>   show serial ports on the gui
>   enable/disable xtermjs depending on the existance of a serial port
> 
>  www/css/ext6-pve.css                 |  7 +++++++
>  www/images/Makefile                  |  5 +++--
>  www/images/icon-serial.svg           |  2 ++
>  www/manager6/button/ConsoleButton.js |  8 ++++++++
>  www/manager6/qemu/Config.js          |  3 +++
>  www/manager6/qemu/HardwareView.js    | 11 ++++++++++-
>  6 files changed, 33 insertions(+), 3 deletions(-)
>  create mode 100644 www/images/icon-serial.svg
> 

Besides my minor nit with the icon:
Series looks OK, tested a bit around, found nothing problematic.