[pve-devel] [PATCH manager 06/19] use NetworkView/NetworkEdit from widget toolkit

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jan 8 13:04:21 CET 2018


On 12/21/17 1:36 PM, Dominik Csapak wrote:
> diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
> index 5ead4878..6131790e 100644
> --- a/www/manager6/node/Config.js
> +++ b/www/manager6/node/Config.js
> @@ -165,7 +165,8 @@ Ext.define('PVE.node.Config', {
>  		    iconCls: 'fa fa-exchange',
>  		    itemId: 'network',
>  		    groups: ['services'],
> -		    xtype: 'pveNodeNetworkView'
> +		    nodename: nodename,
> +		    xtype: 'proxmoxNodeNetworkView'

add?:
, onlineHelp: 'sysadmin_network_configuration'

(see below)

>  		},
>  		{
> [snip]

> diff --git a/www/manager6/node/NetworkView.js b/www/manager6/node/NetworkView.js
> deleted file mode 100644
> index 848aa7b5..00000000
> --- a/www/manager6/node/NetworkView.js
> +++ /dev/null
> @@ -1,351 +0,0 @@
> -Ext.define('PVE.node.NetworkView', {
> -    extend: 'Ext.panel.Panel',
> -
> -    alias: ['widget.pveNodeNetworkView'],
> -
> -    onlineHelp: 'sysadmin_network_configuration',

This does not get set in Proxmox.node.NetworkView
Maybe set it when using it (see above), or, if both widget toolkit users
(PVE & PMG) have this docs reference just keep it there?




More information about the pve-devel mailing list