[pve-devel] [PATCH common 1/2] fork_worker: use correct handle type for POSIX::write
Thomas Lamprecht
t.lamprecht at proxmox.com
Mon Jan 8 09:50:10 CET 2018
Series looks good, reviewed and tested a bit around:
Reviewed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
On 12/27/17 11:15 AM, Wolfgang Bumiller wrote:
> $resfh can be a pipe from POSIX::pipe() or the upid output
> handle, which is an IO::File, so we need to take its
> fileno().
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> Fixes: ed52a8435a6d ("fork_worker: use separate pipe for status messages")
> ---
> Fixes 'Error: unable to read tail' messages produced by starting async
> tasks from the UI.
>
> src/PVE/RESTEnvironment.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
> index 91de875..871f12b 100644
> --- a/src/PVE/RESTEnvironment.pm
> +++ b/src/PVE/RESTEnvironment.pm
> @@ -525,7 +525,7 @@ sub fork_worker {
> if !open(STDIN, "</dev/null");
>
> $outfh = PVE::Tools::upid_open($upid);
> - $resfh = $outfh;
> + $resfh = fileno($outfh);
> }
>
>
>
More information about the pve-devel
mailing list