[pve-devel] [PATCH qemu-server 0/1] Fix #1664: nbd mirror : remove socat tunnel

Alexandre Derumier aderumier at odiso.com
Thu Feb 15 13:43:09 CET 2018


socat tunnel for nbd mirror was introduce here
https://pve.proxmox.com/pipermail/pve-devel/2017-January/024777.html
to workaround when nbd client was hanging on non responding nbd server.

We have added a 30s timeout on socat tunnel, but when we migrate
multiple disks, it can break migration if for example first disk
is already finished and don't send any new datas in the tunnel.

The connect timeout bug has been fixed in qemu 2.9,
so we can remove the socat tunnel now.


Note:

nbd_stop is buggy without the socat tunnel,
it's hanging the qmp socket on source vm
https://bugzilla.redhat.com/show_bug.cgi?id=1482478
That don't break the migration, but source vm qmp stop is hanging,
and the correctly finished after some seconds later.

This is already fixed in my previous nbd qemu patch series
kvm-nbd-client-Fix-regression-when-server-sends-garbage.patch 
(included in pve-qemu-kvm 2.9.1-8)

Alexandre Derumier (1):
  Fix #1664: nbd mirror : remove socat tunnel

 PVE/QemuServer.pm | 46 +---------------------------------------------
 1 file changed, 1 insertion(+), 45 deletions(-)

-- 
2.11.0




More information about the pve-devel mailing list