[pve-devel] [PATCH widget-toolkit] rename pve(Show|Hide)Help events

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Feb 13 14:41:29 CET 2018


On 2/13/18 2:22 PM, Dominik Csapak wrote:
> we renamed them in the helpButton, we also have to rename them here
> this prevented the help button to show up in the vm/ct creation wizard
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  panel/InputPanel.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/panel/InputPanel.js b/panel/InputPanel.js
> index 4add54d..e3a2520 100644
> --- a/panel/InputPanel.js
> +++ b/panel/InputPanel.js
> @@ -5,12 +5,12 @@ Ext.define('Proxmox.panel.InputPanel', {
>  	activate: function() {
>  	    // notify owning container that it should display a help button
>  	    if (this.onlineHelp) {
> -		Ext.GlobalEvents.fireEvent('pveShowHelp', this.onlineHelp);
> +		Ext.GlobalEvents.fireEvent('proxmoxShowHelp', this.onlineHelp);
>  	    }
>  	},
>  	deactivate: function() {
>  	    if (this.onlineHelp) {
> -		Ext.GlobalEvents.fireEvent('pveHideHelp', this.onlineHelp);
> +		Ext.GlobalEvents.fireEvent('proxmoxHideHelp', this.onlineHelp);
>  	    }
>  	}
>      },
> 

Reviewed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>




More information about the pve-devel mailing list