[pve-devel] [Patch manager] Fix the remaining comment.

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Feb 7 13:44:50 CET 2018


On 2/7/18 1:21 PM, Wolfgang Link wrote:
> ---
>  debian/postinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/postinst b/debian/postinst
> index 23355ebd..f67ff8ea 100755
> --- a/debian/postinst
> +++ b/debian/postinst
> @@ -54,7 +54,7 @@ case "$1" in
>      rm -f /etc/init.d/pvenetcommit
>      rm -f /etc/init.d/pve-manager
>  
> -    # create new daily randomize update cronjob if not exist
> +    # randomize daily cronjob for pveupdate to prevent update storm.
>      MIN="$(shuf -i 0-59 -n 1)"
>      HOUR="$(shuf -i 2-5 -n 1)"
>      cat <<EOF >/etc/cron.d/pveupdate
> 

I posted a (not yet reviewed) series [1] cleaning the whole postinst and
friends up. It included a patch adding a systemd timer service to replace
the cron entry [2] and removing this comment completely. As the comment is
non-essential I'd like to wait at least for a review of mine series before
considering applying this (which would result in a merge conflict then).

cheers,
Thomas

[1]: https://pve.proxmox.com/pipermail/pve-devel/2018-January/030433.html
[2]: https://pve.proxmox.com/pipermail/pve-devel/2018-January/030440.html




More information about the pve-devel mailing list