[pve-devel] [PATCH manager] fix #1872 Move button stays on the screen after closing

Dominik Csapak d.csapak at proxmox.com
Mon Aug 20 11:06:14 CEST 2018


this is nearly the exact revert of one of my patches from May [1]

thinking about it, both versions are wrong

we want the hdmove windows closing not instantly, but also not only on 
taskdone, but when the taskviewer window closes

so instead we would have to do something like this:

---8<---

var win = Ext.create('Proxmox.window.TaskViewer',
...
);

win.on('destroy', function() { me.close(); });
win.show();

--->8---

1: https://pve.proxmox.com/pipermail/pve-devel/2018-May/031865.html

On 08/17/2018 11:22 AM, David Limbeck wrote:
> ---
>   www/manager6/qemu/HDMove.js | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/www/manager6/qemu/HDMove.js b/www/manager6/qemu/HDMove.js
> index f08fd316..a5d69bbf 100644
> --- a/www/manager6/qemu/HDMove.js
> +++ b/www/manager6/qemu/HDMove.js
> @@ -33,12 +33,10 @@ Ext.define('PVE.window.HDMove', {
>   	    success: function(response, options) {
>   		var upid = response.result.data;
>   		var win = Ext.create('Proxmox.window.TaskViewer', {
> -		    upid: upid,
> -		    taskDone: function(success) {
> -			me.close();
> -		    }
> +		    upid: upid
>   		});
>   		win.show();
> +		me.close();
>   	    }
>   	});
>   
> 





More information about the pve-devel mailing list