[pve-devel] [PATCH kernel v2 4/4] d/rules: check for accidental perf linkage

Fabian Gr├╝nbichler f.gruenbichler at proxmox.com
Wed Apr 25 12:17:19 CEST 2018


with libraries that are not GPL-2-only compatible, fix previously typoed
variable, and add build-dep on libiberty-dev for CPLUS demangling.

Signed-off-by: Fabian Gr├╝nbichler <f.gruenbichler at proxmox.com>
---
changes since v1:
- switch to HAVE_NO_LIBBFD instead of feature-libbfd
- add build-dep on libiberty-dev
- fix wrong naming of HAVE_CPLUS_DEMANGLE_SUPPORT to force usage of libiberty for demangling

 debian/control.in | 1 +
 debian/rules      | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/debian/control.in b/debian/control.in
index 03cbd00..01d41df 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -7,6 +7,7 @@ Build-Depends: asciidoc,
                bison,
                flex,
                gcc-6 (>= 6.3.0-18+deb9u1),
+               libiberty-dev,
                libssl-dev,
                lintian,
                sed,
diff --git a/debian/rules b/debian/rules
index a84ae5a..8e842ae 100755
--- a/debian/rules
+++ b/debian/rules
@@ -125,7 +125,10 @@ binary: install
 	touch $@
 
 .tools_compile_mark: .compile_mark
-	${MAKE} -C ${KERNEL_SRC}/tools/perf prefix=/usr HAVE_CPLUS_DEMANGLE=1 NO_LIBPYTHON=1 NO_LIBPERL=1 NO_LIBCRYPTO=1 PYTHON=python2.7
+	${MAKE} -C ${KERNEL_SRC}/tools/perf prefix=/usr HAVE_NO_LIBBFD=1 HAVE_CPLUS_DEMANGLE_SUPPORT=1 NO_LIBPYTHON=1 NO_LIBPERL=1 NO_LIBCRYPTO=1 PYTHON=python2.7
+	echo "checking GPL-2 only perf binary for library linkage with incompatible licenses.."
+	! ldd ${KERNEL_SRC}/tools/perf/perf | grep -q -E '\blibbfd'
+	! ldd ${KERNEL_SRC}/tools/perf/perf | grep -q -E '\blibcrypto'
 	${MAKE} -C ${KERNEL_SRC}/tools/perf man
 	# contained in linux-base
 	rm -f ${KERNEL_SRC}/tools/perf/Documentation/perf.1
-- 
2.14.2




More information about the pve-devel mailing list