[pve-devel] [PATCH kernel v2] d/control: add some missing build dependencies

Fabian Gr├╝nbichler f.gruenbichler at proxmox.com
Tue Apr 24 09:38:40 CEST 2018


On Tue, Apr 24, 2018 at 08:07:14AM +0200, Thomas Lamprecht wrote:
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
> 
> changes v1 -> v2:
> * omit libssl-dev for now

seems I was wrong there - libssl-dev is needed for some module signing
scripts (which are LGPL 2.1+), which we don't use, but some users might.

it is already explicitly disabled for the (GPL-2 only) perf binary,
where it would be problematic:

debian/rules:
128:    ${MAKE} -C ${KERNEL_SRC}/tools/perf prefix=/usr HAVE_CPLUS_DEMANGLE=1 NO_LIBPYTHON=1 NO_LIBPERL=1 NO_LIBCRYPTO=1 PYTHON=python2.7

we probably want to add 'feature-libbfd=0' to prevent accidentally
linking with libbfd from binutils-dev (which is GPL-3+ only, and thus
not compatible with GPL-2 only perf).

I'll apply a combination of your v1 and v2 (with libssl-dev and the
comma-dot fix), and send the latter + a check with ldd as separate
patch.

> * replace wrong dot after 'xmlto' with comma
> 
>  debian/control.in | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/debian/control.in b/debian/control.in
> index fa58872..18e8381 100644
> --- a/debian/control.in
> +++ b/debian/control.in
> @@ -5,6 +5,11 @@ Maintainer: Proxmox Support Team <support at proxmox.com>
>  Build-Depends: gcc-6 (>= 6.3.0-18+deb9u1),
>                 lintian,
>                 sed,
> +               flex,
> +               bison,
> +               bc,
> +               asciidoc,
> +               xmlto,
>                 tar,
>  Build-Conflicts: pve-headers- at KVNAME@,
>  Vcs-Git: git://git.proxmox.com/git/pve-kernel
> -- 
> 2.14.2
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



More information about the pve-devel mailing list