[pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

[Fabian Grünbichler]

On Thu, Apr 19, 2018 at 11:02:44AM +0200, Rene Jochum wrote:
> On 2018-04-19 10:16, Fabian Grünbichler wrote:
> > some comments inline (your patch also only applies when ignoring
> > whitespace changes!)
> 
> 
> Hi Fabian,
> 
> thank you for looking into it! Can you give me a tip on making patches
> that apply without ignoring white space changes?

I think your editor or MUA modifies lines only containing whitespace.

e.g., if I diff the patch as you sent it, and the patch exported again
after applying it with '--ignore-whitespace', I see lots of lines where
your original patch has /^$/ (a completely empty line), and the
re-exported one has /^ $/ (a line containing a single space).

the former is not valid patch syntax, because the first character
indicates added (+), removed (-) or context ( ), the latter means an
otherwise empty context line.

> Will implement all the given recommendations now.

great :)