[pve-devel] Long standing bug in "override_for_missing_acs_capabilities.patch"

[Dominik Csapak]

On 04/18/2018 10:57 AM, Daniel Boothby wrote:
> Hopefully this is the right place to send this to, because I tried a post
> on the forum and the issue seems to have been missed.
> 
> In the "override_for_missing_acs_capabilities.patch" file at line 184
> (v2.13.3), the last patch chunk end marker has an incorrect line number.
> This issue appears to have persisted across several revisions of the
> proxmox acs patch file rendering the ACS override functionality broken for
> a long time.
> 
> In the current stretch master v2.13.3 of the file, line 184 reads:
> 
>      @@ -4368,6 +4469,7 @@ static const struct pci_dev_acs_enabled {
> 
> But as this chunk is only adding a single line the block header should
> actually be:
> 
>      @@ -4368,6 +4368,7 @@ static const struct pci_dev_acs_enabled {
> 
> 
> If there's a better place to open a bug ticket somewhere, please let me
> know!
> 
> Thanks,
> Dan
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 

i am guessing you look at an old version?

https://git.proxmox.com/?p=pve-kernel.git;a=blob;f=patches/kernel/0003-pci-Enable-overrides-for-missing-ACS-capabilities-4..patch;h=a6b43915703f36734d2b8797325cce2a371ec6f6;hb=refs/heads/master

shows totally different line numbers...