[pve-devel] [Patch storage 2/2] fix #1691: increase timeout

Fabian Gr├╝nbichler f.gruenbichler at proxmox.com
Tue Apr 17 15:05:51 CEST 2018


On Tue, Apr 17, 2018 at 02:39:06PM +0200, Wolfgang Link wrote:
> A ZFS storage under heavy load can take more time.
> ---
>  PVE/Storage/ZFSPoolPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
> index 9680a94..b63fc27 100644
> --- a/PVE/Storage/ZFSPoolPlugin.pm
> +++ b/PVE/Storage/ZFSPoolPlugin.pm
> @@ -211,7 +211,7 @@ sub alloc_image {
>  	$class->zfs_create_zvol($scfg, $volname, $size);
>  	my $devname = "/dev/zvol/$scfg->{pool}/$volname";
>  
> -	my $timeout = 10;
> +	my $timeout = 30;

you need to check whether you are in a worker or not, just like for the
other timeouts in this plugin. if you are in a worker, you can bump the
timeout to a lot more than 30 seconds. but if you are not in a worker,
10 seconds is already close to the max (you don't know if there is not
more than one operation, and 10 seconds already means at most two
operations + overhead + error handling).

>  	for (my $i = 1; $i <= $timeout; $i++) {
>  	    last if -b $devname;
>  	    die "Timeout: no zvol after $timeout sec found.\n"
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



More information about the pve-devel mailing list