[pve-devel] [Patch V2 guest-common] fix #1694: Replication risks permanently losing sync in high loads due to timeout bug

[Dietmar Maurer]

> @@ -293,12 +303,16 @@ sub replicate {
>  	die $err;
>      }
>  
> -    # remove old snapshots because they are no longer needed
> -    $cleanup_local_snapshots->($last_snapshots, $last_sync_snapname);
> +    eval {
> +	# remove old snapshots because they are no longer needed
> +	$cleanup_local_snapshots->($last_snapshots, $last_sync_snapname);

Seems to me that $cleanup_local_snapshots->() never raise an exception, so this
code does not
really makes sense? At least there is no need to catch errors from
$cleanup_local_snapshots ?