[pve-devel] BUG? New software package available

[Fabian Grünbichler]

On Wed, Apr 11, 2018 at 04:24:16PM +0200, Detlef Bracker wrote:
> Dear,
> 
> in last mail of this thread Fabian write:
> 
> the bug is only in the kernel module code, so the ZFS user space
> packages have not been updated (and don't need to be in PVE's case).
> 
> and before Lindsay write:
> 
> I notice that zfs 0.7.7 has arrived in the no-sub repo – it has a reasonably serious dataloss bug:
> 
> See last mails in this thread:
> 
> https://pve.proxmox.com/pipermail/pve-user/2018-April/169434.html
> 
> But I understand, that you chanche now with updates not only the kernel, why
> this is in pve:
> 
> zfs-initramfs: 0.7.6-pve1~bpo9 ==> 0.7.7-pve1~bpo9
> zfsutils-linux: 0.7.6-pve1~bpo9 ==> 0.7.7-pve1~bpo9
> libzfs2linux: 0.7.6-pve1~bpo9 ==> 0.7.7-pve1~bpo9
> libzpool2linux: 0.7.6-pve1~bpo9 ==> 0.7.7-pve1~bpo9
> 
> So what is now?
> 
> Regards
> 
> Detlef

maybe the following timeline helps:

- 2018-04-06 ~11:30: upload of ZFS 0.7.7 to pvetest - both userspace
  (lib* / zfs* packages) and kernel modules (pve-kernel-*)
- 2018-04-09 ~10:00: revert of buggy commit, rebuild of pve-kernel-*
- 2018-04-09 ~15:30: upload of fixed pve-kernel-* packages to pvetest
- 2018-04-09 ~23:00: upstream tags ZFS on Linux 0.7.8 with the buggy
  commit reverted
- 2018-04-10 ~11:00: sync of pvetest to pve-no-subscription

since our revert happened faster than upstream's regression fix release
(0.7.8), the version numbers are different. since the buggy code was
only on the kernel side, we did not rebuild the ZFS userspace packages
(we did revert the commit in git though for build related reasons - the
kernel modules and the userspace packages get built from the exact same
source).

as has been stated multiple times on pve-users and the forum, unless you
are running one of the exact kernels (PACKAGE NAME AND PACKAGE VERSION!)
listed below, you are not affected:

pve-kernel-4.15.15-1-pve in version 4.15.15-5
pve-kernel-4.13.16-1-pve in version 4.13.16-46

both of those kernels were only the default/latest kernel while they
were in pvetest, between last Friday and this Monday. they only entered
pve-no-subscription (on Tuesday) after already being replaced by the
fixed packages (on Monday afternoon). if you didn't install packages
from pvetest during that time period you were not at risk at all, unless
you manually downgraded kernel packages to one of the affected ones in
the past few days.

any other kernel package (again, ABI/package name AND package version
matters when checking!) was not affected. the ZFS userspace package
version is entirely irrelevant for assessing whether you are/were
affected or not, and down- or upgrading the ZFS packages does not change
anything.