[pve-devel] [PATCH container] remove --skip-old-files from tar restore options

Tom Weber pve at junkyard.4t2.com
Tue Sep 26 15:29:51 CEST 2017


this breaks ownership of mountpoints in containers
(leaves them at root:root)
---
 src/PVE/LXC/Create.pm | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm
index 1f21e06..ac632de 100644
--- a/src/PVE/LXC/Create.pm
+++ b/src/PVE/LXC/Create.pm
@@ -77,11 +77,6 @@ sub restore_archive {
                @PVE::Storage::Plugin::COMMON_TAR_FLAGS,
                '-C', $rootdir];
 
-    # skip-old-files doesn't have anything to do with time (old/new), but is
-    # simply -k (annoyingly also called --keep-old-files) without the 'treat
-    # existing files as errors' part... iow. it's bsdtar's interpretation of -k
-    # *sigh*, gnu...
-    push @$cmd, '--skip-old-files';
     push @$cmd, '--anchored';
     push @$cmd, '--exclude' , './dev/*';
 
-- 
2.7.4




More information about the pve-devel mailing list