[pve-devel] [PATCH v3] Move read_password to pve-common's CLIHandler
Wolfgang Bumiller
w.bumiller at proxmox.com
Tue Sep 26 14:01:01 CEST 2017
Rebase/redo of the old series. Note that I don't see the need to keep
read_password() wrapping an implementation method in all 3 CLI tools
when currently they all need to do the same thing. The only thing this
did was pass a name to the ReadLine ctor which is not all that useful.
If no verification is desired, you can still replace the method in a
derived class and call the CLIHandler's version with modified
parameters.
Changes:
- Removed read_password() from pct and pveum entirely.
- Providing a default read_password() implementation in CLIHandler.
- Disable the access to and recording of history in the readline
instance rather than deleting the entries afterwards.
- Include the libterm-readline-gnu-perl dependency in pve-common (as it
was previously only in pve-manager).
Wolfgang Bumiller (1):
CLIHandler: add a default read_password implementation
pct: remove read_password
pveum: remove read_password
pvesh: use the CLIHandler's read_password
--
2.11.0
More information about the pve-devel
mailing list