[pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

[Emmanuel Kasper]

On 09/21/2017 10:50 AM, Wolfgang Bumiller wrote:
> On Thu, Sep 21, 2017 at 10:26:46AM +0200, Emmanuel Kasper wrote:
>> Mainly to allow libguestfs and associated tools to work with our qemu binary.
>>
>> libguestfs tests at run timethe output of qemu -help and qemu -device ?
>> to detect which features it can use, so it should not
>> depend on which configure flags were used when compiling our qemu binary.
>> ---
>>  debian/control            | 4 ++--
>>  debian/pve-qemu-kvm.links | 1 +
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>  create mode 100644 debian/pve-qemu-kvm.links
>>
>> diff --git a/debian/control b/debian/control
>> index ecf65c2..591cb61 100644
>> --- a/debian/control
>> +++ b/debian/control
>> @@ -45,8 +45,8 @@ Depends: ${shlibs:Depends}, ${misc:Depends},
>>   numactl,
>>   libjemalloc1,
>>   libjpeg62-turbo
>> -Conflicts: qemu, qemu-kvm, qemu-utils, kvm, pve-kvm, pve-qemu-kvm-2.6.18
>> -Provides: qemu-utils
>> +Conflicts: qemu, qemu-kvm, qemu-utils, qemu-system-x86, kvm, pve-kvm, pve-qemu-kvm-2.6.18
>> +Provides: qemu-utils, qemu-system-x86
> 
> To provide qemu-system-x86 we'd need to also ship a
> /usr/bin/qemu-system-i386 (which is not the same as qemu-system-x86_64).
I was not sure about this, as stated in the cover letter

after reading
https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02134.html
the main difference between those two binaries is that
/usr/bin/qemu-system-i386  is faster when running 16/32 bit OSes

since we've been running 32 bits OSes on our 64 bits qemu-system for a
long time here without problem I don't see a compatibility problem here
if  the /usr/bin/qemu-system-i386 and /usr/bin/qemu-system-x86_64 points
to the same binary. or ?

>>  Replaces: pve-kvm, pve-qemu-kvm-2.6.18, qemu-utils
>>  Description: Full virtualization on x86 hardware
>>   Using KVM, one can run multiple virtual PCs, each running unmodified Linux or
>> diff --git a/debian/pve-qemu-kvm.links b/debian/pve-qemu-kvm.links
>> new file mode 100644
>> index 0000000..8e769d8
>> --- /dev/null
>> +++ b/debian/pve-qemu-kvm.links
>> @@ -0,0 +1 @@
>> +/usr/bin/kvm /usr/bin/qemu-system-x86_64
> 
> I'd rather have the rules file updated to not rename the binary and
> instead make /usr/bin/kvm the symlink (also from within the rules file
> since it depends on $(ARCH) there (and amd64 would have to be translated
> to x86_64...)).

agree, makes sense to me too