[pve-devel] [PATCH access-control v2 2/3] Remove unused Dumper use

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Sep 21 09:09:58 CEST 2017


On 09/20/2017 05:10 PM, Philip Abernethy wrote:
> ---
>   PVE/API2/Role.pm | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm
> index d6d17db..107523e 100644
> --- a/PVE/API2/Role.pm
> +++ b/PVE/API2/Role.pm
> @@ -7,8 +7,6 @@ use PVE::AccessControl;
>   
>   use PVE::SafeSyslog;
>   
> -use Data::Dumper; # fixme: remove
> -
>   use PVE::RESTHandler;
>   
>   use base qw(PVE::RESTHandler);
> 


Looks good.
There are some other Dumper includes around which may be obsolete:
PVE/Auth/Plugin.pm PVE/AccessControl.pm PVE/API2/ACL.pm PVE/API2/User.pm

Could you verify their obsoleteness and remove them here too
(evtl. in a v3 if that would be warranted)




More information about the pve-devel mailing list