[pve-devel] Kernel: CONFIG_MLX4_EN_VXLAN=y not present anymore

[Thomas Lamprecht]

Hi,

On 09/20/2017 11:55 AM, Alexander Schmid wrote:
> Hello,
> 
> i just noticed that CONFIG_MLX4_EN_VXLAN, what is important for vxlan hw offload with ConnectX-3, is not set anymore.
> 

The reason for this is that it does not exist anymore,
cannot grep it in current git tree. This commit removed it,
or better said made it unnecessary - its default on now:

commit a831274a1346913c145797ddee6f39e30e061318
Author: Alexander Duyck <aduyck at mirantis.com>
Date:   Thu Jun 16 12:22:30 2016 -0700

     mlx4_en: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

     This change replaces the network device operations for adding or removing a
     VXLAN port with operations that are more generically defined to be used for
     any UDP offload port but provide a type.  As such by just adding a line to
     verify that the offload type is VXLAN we can maintain the same
     functionality.

     In addition I updated the socket address family check so that instead of
     excluding IPv6 we instead abort of type is not IPv4.  This makes much more
     sense as we should only be supporting IPv4 outer addresses on this
     hardware.

     Signed-off-by: Alexander Duyck <aduyck at mirantis.com>
     Signed-off-by: David S. Miller <davem at davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlx4/Kconfig b/drivers/net/ethernet/mellanox/mlx4/Kconfig
index 9ca3734ebb6b..5098e7f21987 100644
--- a/drivers/net/ethernet/mellanox/mlx4/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx4/Kconfig
@@ -24,13 +24,6 @@ config MLX4_EN_DCB

           If unsure, set to Y

-config MLX4_EN_VXLAN
-       bool "VXLAN offloads Support"
-       default y
-       depends on MLX4_EN && VXLAN && !(MLX4_EN=y && VXLAN=m)
-       ---help---
-         Say Y here if you want to use VXLAN offloads in the driver.
-
  config MLX4_CORE
         tristate
         depends on PCI

[...]

For full commit see:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a831274a1346913c145797ddee6f39e30e061318

cheers,
Thomas

> I see it on kernel 4.4.15-1-pve:
> 
> # uname -a
> Linux cl1-1-s0c1 4.4.15-1-pve #1 SMP Thu Jul 28 10:54:13 CEST 2016 x86_64 GNU/Linux
> 
> # cat /boot/config-`uname -r`|grep MLX4_
> CONFIG_MLX4_EN=m
> CONFIG_MLX4_EN_DCB=y
> CONFIG_MLX4_EN_VXLAN=y
> CONFIG_MLX4_CORE=m
> CONFIG_MLX4_DEBUG=y
> CONFIG_MLX4_INFINIBAND=m
> 
> 
> currently it looks like this:
> 
> # uname -a
> Linux pvedev 4.10.17-3-pve #1 SMP PVE 4.10.17-21 (Thu, 31 Aug 2017 14:57:17 +0200) x86_64 GNU/Linux
> 
> #cat /boot/config-`uname -r`|grep MLX4_
> CONFIG_MLX4_EN=m
> CONFIG_MLX4_EN_DCB=y
> CONFIG_MLX4_CORE=m
> CONFIG_MLX4_DEBUG=y
> CONFIG_MLX4_INFINIBAND=m
> 
> Any reason it was disabled / any chance to get it back ?
> 
> Thanks,
> Alex
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel