[pve-devel] [PATCH manager] VM.Snapshot.Rollback privilege added

[Thomas Lamprecht]

On 09/13/2017 12:30 PM, Matthias Urban wrote:
> VM.Snapshot.Rollback privilege added
> 

Tested and reviewed whole series.

Only thing is: I'm not quite sure that its OK where you put the new
priv. As this affects only autogenerated Roles and does not gives
more privs I can live with it, but would be nice to discuss and
resolve this as it goes in.

Besides that, looks OK.

cheers,
Thomas

> Signed-off-by: Matthias Urban <matthias.urban at pure-systems.com>
> ---
>   www/manager6/lxc/Config.js  | 2 +-
>   www/manager6/qemu/Config.js | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js
> index fbaccefe..12a4b12d 100644
> --- a/www/manager6/lxc/Config.js
> +++ b/www/manager6/lxc/Config.js
> @@ -200,7 +200,7 @@ Ext.define('PVE.lxc.Config', {
>   	    });
>   	}
>   
> -	if (caps.vms['VM.Snapshot']) {
> +	if (caps.vms['VM.Snapshot'] || caps.vms['VM.Snapshot.Rollback']) {
>   	    me.items.push({
>   		title: gettext('Snapshots'),
>   		iconCls: 'fa fa-history',
> diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
> index 75454d8e..31cab970 100644
> --- a/www/manager6/qemu/Config.js
> +++ b/www/manager6/qemu/Config.js
> @@ -234,7 +234,7 @@ Ext.define('PVE.qemu.Config', {
>   	    });
>   	}
>   
> -	if (caps.vms['VM.Snapshot'] && !template) {
> +	if ((caps.vms['VM.Snapshot'] || caps.vms['VM.Snapshot.Rollback']) && !template) {
>   	    me.items.push({
>   		title: gettext('Snapshots'),
>   		iconCls: 'fa fa-history',
>