[pve-devel] [PATCH qemu-server v8 1/6] Force overwriting existing compressed man pages and symbolic links

[Thomas Lamprecht]

On 09/13/2017 04:10 PM, Emmanuel Kasper wrote:
> This allows calling the 'make install' target twice in a row.

Looks OK, we overwrite everything else so why not the man pages.

This can be already applied even if we would say the current
iteration of this series still lacks something, IMO, no need
to drag this along...

Also, FYI: I assume you made this patch in the first place to
allow faster testing your changes by just doing `make install`
circumventing the slower package build of `make dinstall` where
this patch wouldn't be needed?
If so, you could like to use perl's -I switch:

> -Idirectory
>          Directories specified by -I are prepended to the search
>          path for modules (@INC).


For example, in your case you could do the following from inside the
qemu-servers top level directory:

perl -I. ./qm importovf ...

Just for the case that you did not know this all already :)

cheers,
Thomas

> ---
>   Makefile | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index e9482f2..998d17a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -69,12 +69,12 @@ install: ${PKGSOURCES}
>   	install -D -m 0644 modules-load.conf ${DESTDIR}/etc/modules-load.d/qemu-server.conf
>   	install -m 0755 qmextract ${DESTDIR}${LIBDIR}
>   	install -m 0644 qm.1 ${DESTDIR}/${MAN1DIR}
> -	gzip -9 -n ${DESTDIR}/${MAN1DIR}/qm.1
> +	gzip -9 -n -f ${DESTDIR}/${MAN1DIR}/qm.1
>   	install -m 0644 qmrestore.1 ${DESTDIR}/${MAN1DIR}
> -	gzip -9 -n ${DESTDIR}/${MAN1DIR}/qmrestore.1
> +	gzip -9 -n -f ${DESTDIR}/${MAN1DIR}/qmrestore.1
>   	install -m 0644 qm.conf.5 ${DESTDIR}/${MAN5DIR}
> -	gzip -9 -n ${DESTDIR}/${MAN5DIR}/qm.conf.5
> -	cd ${DESTDIR}/${MAN5DIR}; ln -s qm.conf.5.gz vm.conf.5.gz
> +	gzip -9 -n -f ${DESTDIR}/${MAN5DIR}/qm.conf.5
> +	cd ${DESTDIR}/${MAN5DIR}; ln -s -f qm.conf.5.gz vm.conf.5.gz
>   
>   .PHONY: deb
>   deb: ${DEB}
>