[pve-devel] [PATCH manager v2 00/10] Display the SCSI controller type when adding a new drive

Emmanuel Kasper e.kasper at proxmox.com
Tue Sep 12 14:44:39 CEST 2017


changes since v1:
 * from Dominik hints:
   * use a fixed hint for bus id selector, so we can flex the controller type
   on the remaining width
   * fixe VirtIO typo
 * from Wolfgang B hints:
   * make controller type selector non editable
 * also write 'VirtIO blk' without hyphen in the controller list

NB: still open for better casing of VirtIO blk if anyone finds one ...

I plan an update for the documentation after this serie is applied

Emmanuel Kasper (10):
  Do not change the SCSI controller type when iothread was selected
  Move Wizard static properties to class body
  Do not use 'autoselect' as a boolean when preselecting a bus
  Remove unused noScsi parameter
  Save the components we found via down() in a variable for later reuse.
  Use the noVirtIO ControllerSelector property to build the list of
    controllers
  Enhance BusStypeSelector with the SCSI controller description
  Improve the display names of VirtIO blk and VirtIO SCSI controllers
  Make room in QemuWizard and Edit Window so that the larger combo boxes
    properly fit
  Propagate the SCSI hw to the Hard Disk panel when selecting an OS

 www/manager6/Utils.js                   |  4 +-
 www/manager6/form/BusTypeSelector.js    | 58 ++++++++++++++++++++++------
 www/manager6/form/ControllerSelector.js | 67 +++++++++++++++------------------
 www/manager6/qemu/CDEdit.js             |  3 ++
 www/manager6/qemu/CreateWizard.js       |  3 +-
 www/manager6/qemu/HDEdit.js             | 12 +++---
 www/manager6/qemu/OSTypeEdit.js         | 11 ++++--
 www/manager6/window/Edit.js             |  3 ++
 www/manager6/window/Wizard.js           | 16 ++++----
 9 files changed, 109 insertions(+), 68 deletions(-)

-- 
2.11.0





More information about the pve-devel mailing list