[pve-devel] [PATCH manager v2 01/10] Do not change the SCSI controller type when iothread was selected

Emmanuel Kasper e.kasper at proxmox.com
Tue Sep 12 14:44:40 CEST 2017


This was happening without giving the user feedback, and changes a value
which should be set somewhere in the Options Panel.
---
 www/manager6/qemu/CreateWizard.js | 2 +-
 www/manager6/qemu/HDEdit.js       | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index c3e2fc8a..944309a6 100644
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -161,7 +161,7 @@ Ext.define('PVE.qemu.CreateWizard', {
 			var nodename = kv.nodename;
 			delete kv.nodename;
 
-			if (me.qemuScsiController && !kv.scsihw) {
+			if (me.qemuScsiController) {
 			    kv.scsihw = me.qemuScsiController;
 			}
 
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index e7535f50..464aa49c 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -115,10 +115,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
 
 	if (values.iothread) {
 	    me.drive.iothread = 'on';
-	    // do not silently change a VM-wide option after creating it
-	    if (me.insideWizard) {
-		params.scsihw = 'virtio-scsi-single';
-	    }
 	} else {
 	    delete me.drive.iothread;
 	}
-- 
2.11.0





More information about the pve-devel mailing list