[pve-devel] [PATCH manager 08/10] Improve the display names of VirtIO-blk and VirtIO SCSI controllers

[Dominik Csapak]

this is ok , but if this gets applied, please also correct the 
documentation, as we mention scsi single etc. there

On 09/06/2017 10:15 AM, Emmanuel Kasper wrote:
> SCSI is redundant in the VirtIO SCSI controller type.
> VirtIO-blk allows to better understand the different choices in the Combobox
> and is also the name used by Qemu upstream.
> ---
>   www/manager6/Utils.js                | 4 ++--
>   www/manager6/form/BusTypeSelector.js | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 0b850977..9f79506a 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -202,9 +202,9 @@ Ext.define('PVE.Utils', { utilities: {
>   	} else if (value === 'megasas') {
>   	    return 'MegaRAID SAS 8708EM2';
>   	} else if (value === 'virtio-scsi-pci') {
> -	    return 'VirtIO SCSI';
> +	    return 'VirtIO';
>   	} else if (value === 'virtio-scsi-single') {
> -	    return 'VirtIO SCSI single';
> +	    return 'VirtIO single';
>   	} else if (value === 'pvscsi') {
>   	    return 'VMware PVSCSI';
>   	} else {
> diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js
> index 0b37857e..95db8d1b 100644
> --- a/www/manager6/form/BusTypeSelector.js
> +++ b/www/manager6/form/BusTypeSelector.js
> @@ -5,7 +5,7 @@ Ext.define('PVE.form.BusTypeSelector', {
>       // ordering matters
>       busList: [
>   	    ['ide', 'IDE'],
> -	    ['virtio', 'VirtIO'],
> +	    ['virtio', 'VirtIO-blk'],
>   	    ['scsi', 'SCSI'],
>   	    ['sata', 'SATA']
>       ],
>