[pve-devel] [PATCH manager 0/3] Turn the Online checkbox of the Migrate Window into a displayfield

[Emmanuel Kasper]

On 09/07/2017 11:39 AM, Dominik Csapak wrote:
> On 08/24/2017 11:45 AM, Emmanuel Kasper wrote:
>> This checkbox had no use, as checking/unchecking it would not be able
>> to change the migration type.
>> (see details in third patch).
>> I also took the opportunity to rewrite the component with a
>> ViewController, and this needed
>> a helper to set the help during the component instanciation using a
>> config object.
>>
>> Emmanuel Kasper (3):
>>    Allow to set the onlineHelp via a config Object
>>    Rework Migrate Window with declarative synthax
>>    Turn the offline/online checkbox of the Migrate Windows into a
>>      displayfield
>>
>>   www/manager6/button/HelpButton.js |   6 +
>>   www/manager6/window/Migrate.js    | 231
>> +++++++++++++++++++++-----------------
>>   2 files changed, 132 insertions(+), 105 deletions(-)
>>
> 
> looks good to me
> 
> an afterthought:
> 
> would it be good to show in the window if the guest is managed by ha?
> (the migration behavior differs then a bit; notably that the migration
> is not started instantly)

yep timing differs, but since otherwise the behaviour is the same, the
task window coming with "requesting HA migration" provides IMHO enough
information

or are they cases when the actual migration will happen differently when
the VM is HA managed ?