[pve-devel] applied: [PATCH qemu-server] update_vm: sort logged parameters
Wolfgang Bumiller
w.bumiller at proxmox.com
Thu Sep 7 10:23:49 CEST 2017
applied to master & stable-4
On Wed, Sep 06, 2017 at 11:32:13AM +0200, Fabian Grünbichler wrote:
> otherwise the (log) output looks really strange when mass-updating VMs, e.g.:
> update VM 400001: -scsi1 somestore:64 -scsi0 somestore:64 -ide2 isostore:iso/somefile.iso,media=cdrom
> update VM 400002: -ide2 isostore:iso/somefile.iso,media=cdrom -scsi1 somestore:64 -scsi0 somestore:64
> update VM 400003: -scsi0 somestore:64 -ide2 isostore:iso/somefile.iso,media=cdrom -scsi1 somestore:64
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index aa7c832..2f4a023 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -908,7 +908,7 @@ my $update_vm_api = sub {
> my $background_delay = extract_param($param, 'background_delay');
>
> my @paramarr = (); # used for log message
> - foreach my $key (keys %$param) {
> + foreach my $key (sort keys %$param) {
> push @paramarr, "-$key", $param->{$key};
> }
>
> --
> 2.11.0
More information about the pve-devel
mailing list