[pve-devel] [PATCH] add log for ipfilter, macfilter && ipv6 router-advertisement

[Alexandre DERUMIER]

>>well.. do a
>>$ grep '$rule->' Firewall.pm

yes, sure, but I mean we already also use it in this way.
Anyway, the variable is local inside the if(... )

----- Mail original -----
De: "Tom Weber" <pve at junkyard.4t2.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Jeudi 7 Septembre 2017 09:41:17
Objet: Re: [pve-devel] [PATCH] add log for ipfilter, macfilter && ipv6 router-advertisement

Am Donnerstag, den 07.09.2017, 09:30 +0200 schrieb Alexandre DERUMIER: 
> > 
> > > 
> > > you are aware that $rule is used elsewhere and in a totally 
> > > different 
> > > way? just look in ruleset_add_group_rule. Thats why I named it 
> > > $matchrule initially to avoid confusion. 
> we already used it like this in: 
> 
> 
> 
> sub ruleset_addlog { 
> ... 
> $logrule = "$rule $logrule" if defined($rule); 
> } 
> 
> so I think it's fine. 

well.. do a 
$ grep '$rule->' Firewall.pm 


_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel